Re: [dm-devel] Write protected devices, unexpected dm-multipath queueing

[Mike Snitzer <snitzer redhat com>]

On Fri, Jan 06 2012 at  5:32pm -0500,
Mike Snitzer <snitzer redhat com> wrote:

> On Fri, Jan 06 2012 at  2:30pm -0500,
> Christophe Varoqui <christophe varoqui gmail com> wrote:
> 
> > Hannes, list,
> > 
> > reading your kernel path there
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=63583cca745f440167bf27877182dc13e19d4bcf
> > I wonder if this is expected that a write io on a write protected device
> > is returned to the queue ? I would have guessed it qualified as
> > TARGET_ERROR, hence not retryable (and not causing path invalidation).
> > 
> > In the following log the sense code is clearly seen as 
> > Sense Key : Data Protect [current]
> > Add. Sense: Write protected
> > 
> > The log is grabbed from a el6 kernel rev. 131 which include the
> > mentioned patch (since rev. 110 iirc).
> > 
> > Care to confirm something is fishy there ?
> 
> scsi_check_sense() needs to be trained to return TARGET_ERROR for this
> case.
> 
> The commit you referenced wasn't meant to have covered _every_ possible
> TARGET_ERROR case.

Hmm, but looking closer that commit _does_ return TARGET_ERROR for
DATA_PROTECT.

I need to dig deeper, but I think Hannes gets back to work on Monday.

Mike