[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[dm-devel] [PATCH] block: do not artificially constrain max_sectors for stacking drivers
- From: Mike Snitzer <snitzer redhat com>
- To: "Chauhan, Vijay" <Vijay Chauhan netapp com>
- Cc: axboe kernel dk, "Martin K. Petersen" <martin petersen oracle com>, linux-kernel vger kernel org, "Stankey, Robert" <Robert Stankey netapp com>, "Moger, Babu" <Babu Moger netapp com>, "dm-devel redhat com" <dm-devel redhat com>
- Subject: [dm-devel] [PATCH] block: do not artificially constrain max_sectors for stacking drivers
- Date: Mon, 9 Jul 2012 10:14:16 -0400
blk_set_stacking_limits is intended to allow stacking drivers to build
up the limits of the stacked device based on the underlying devices'
limits. But in the case of 'max_sectors' the default of
BLK_DEF_MAX_SECTORS (1024) doesn't allow the stacking driver to inherit
a max_sectors larger than 1024.
It is now clear that this artificial limit is getting in the way so
change blk_set_stacking_limits's max_sectors to UINT_MAX (which allows
stacking drivers like dm-multipath to inherit 'max_sectors' from the
underlying paths).
Reported-by: Vijay Chauhan <vijay chauhan netapp com>
Signed-off-by: Mike Snitzer <snitzer redhat com>
Cc: Martin K. Petersen <martin petersen oracle com>
---
block/blk-settings.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/block/blk-settings.c b/block/blk-settings.c
index d3234fc..565a678 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -143,8 +143,7 @@ void blk_set_stacking_limits(struct queue_limits *lim)
lim->discard_zeroes_data = 1;
lim->max_segments = USHRT_MAX;
lim->max_hw_sectors = UINT_MAX;
-
- lim->max_sectors = BLK_DEF_MAX_SECTORS;
+ lim->max_sectors = UINT_MAX;
}
EXPORT_SYMBOL(blk_set_stacking_limits);
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]