Re: [dm-devel] [RFC PATCH] block: all callers should check blkdev_issue_flush's return

[Jeff Moyer <jmoyer redhat com>]

Mike Snitzer <snitzer redhat com> writes:

> It is concerning that a FLUSH may fail but the blkdev_issue_flush
> callers assume it will always succeed.
>
> Each blkdev_issue_flush caller should come to terms with the reality
> that a FLUSH may fail -- the file_operations' .fsync methods in
> particular.  nilfs2 is the only filesystem that checks
> blkdev_issue_flush's return.

Yeah, as it stands, it looks like in many cases fsync won't return an
error if a flush fails.  That's bad.