[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] [PATCH] dm-mpath: Track invalid map_context
- From: Alasdair G Kergon <agk redhat com>
- To: Hannes Reinecke <hare suse de>
- Cc: dm-devel redhat com, Alasdair Kergon <akg redhat com>, Mike Snitzer <snitzer redhat com>
- Subject: Re: [dm-devel] [PATCH] dm-mpath: Track invalid map_context
- Date: Mon, 19 Mar 2012 15:20:07 +0000
On Mon, Mar 19, 2012 at 04:15:28PM +0100, Hannes Reinecke wrote:
> - if (r < 0 || r == DM_MAPIO_REQUEUE)
> + if (r < 0 || r == DM_MAPIO_REQUEUE) {
> mempool_free(mpio, m->mpio_pool);
> + map_context->ptr = NULL;
> + }
What about the other places that do mempool_free() ?
Should they clear it too?
Is it better to swap the statement order - clear it *before*
freeing i
Alasdair
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]