[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] Fix I/O counts in vmstat




On Wed, 21 Mar 2012, Jun'ichi Nomura wrote:

> Hi Mikulas,
> 
> > The decision whether bio is counted or not is made by the code that
> > submits the bio. This leads to some problems:
> 
> How about convering dm targets to use generic_make_request?

The problem would be raid1 resynchronization. There are no incoming bios 
when resynchronizing, but the administrator still needs to see the 
resynchronization workload in vmstat. The code path that submits bios for 
resynchronization is the same as the path that handles write requests.

Also dm-over-loop would still result in double-counting, even if we use 
generic_make_request in dm.

Mikulas

> Since submit_bio counts vm events, it seems natural for
> caller to decide which function to use.
> Device driver does not know whether the requested I/O is
> for vm-to-device or device-to-device.
> We could still use iostat to measure throughput of individual
> block devices. 
> 
> Thanks,
> -- 
> Jun'ichi Nomura, NEC Corporation
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]