[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] [PATCH 0/2] multipath: compile cleanup
- From: Christophe Varoqui <christophe varoqui gmail com>
- To: Benjamin Marzinski <bmarzins redhat com>
- Cc: device-mapper development <dm-devel redhat com>, Christophe Varoqui <christophe varoqui gmail com>
- Subject: Re: [dm-devel] [PATCH 0/2] multipath: compile cleanup
- Date: Fri, 25 May 2012 07:20:53 +0200
On jeu., 2012-05-24 at 23:57 -0500, Benjamin Marzinski wrote:
> When the multipath code is compiled with the standard redhat rpm cflags,
> there are a number of warnings that get issued, some about real problems.
>
> These patches switch multipath to use those cflags, and then clean up
> warnings. If people want upstream to continue using the existing cflags,
> I don't particularly mind. I really included the first patch to make sure
> people can see the warnings that the second patch corrects.
>
> Also, some of the warnings are for actual errors, and how to fix them is
> obvious. Others won't actually cause problems, and if people object to
> the changes I made to make them go away, I'm happy to fix them differently.
>
Merged.
Thanks.
> Benjamin Marzinski (2):
> multipath: Build with standard rpm cflags
> multipath: Fix warnings from stricter compile options.
>
> Makefile.inc | 6 +++++-
> libmpathpersist/mpath_persist.c | 10 +++++++---
> libmpathpersist/mpath_pr_ioctl.c | 9 +++++++++
> libmultipath/alias.c | 8 ++++++--
> mpathpersist/main.c | 2 --
> multipathd/main.c | 24 +++++++++++++++++++-----
> 6 files changed, 46 insertions(+), 13 deletions(-)
>
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]