[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info
- From: "Jun'ichi Nomura" <j-nomura ce jp nec com>
- To: Kent Overstreet <koverstreet google com>
- Cc: axboe kernel dk, linux-bcache vger kernel org, linux-kernel vger kernel org, linux-fsdevel vger kernel org, device-mapper development <dm-devel redhat com>, mpatocka redhat com, vgoyal redhat com, sage newdream net, bharrosh panasas com, tj kernel org, yehuda hq newdream net, agk redhat com, drbd-dev lists linbit com
- Subject: Re: [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info
- Date: Mon, 28 May 2012 20:41:18 +0900
On 05/28/12 09:57, Jun'ichi Nomura wrote:
> On 05/26/12 05:25, Kent Overstreet wrote:
>> - pools->bs = bioset_create(pool_size, 0);
>> + pools->bs = bioset_create(pool_size,
>> + offsetof(struct dm_rq_clone_bio_info, orig));
>> if (!pools->bs)
>> goto free_tio_pool_and_out;
>
> Did you mean offset of *clone*?
> "offsetof(struct dm_rq_clone_bio_info, orig)" is zero.
Additional comment:
frontpad is not necessary if type is DM_TYPE_BIO_BASED.
Please check conditional switches done in the same function for
pools->tio_pool.
--
Jun'ichi Nomura, NEC Corporation
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]