Re: [dm-devel] calling dm_io

["Kasatkin, Dmitry" <dmitry kasatkin intel com>]

On Thu, Nov 8, 2012 at 7:22 PM, Alasdair G Kergon <agk redhat com> wrote:
> On Thu, Nov 08, 2012 at 06:04:44PM +0200, Kasatkin, Dmitry wrote:
>> So it expects caller to initialize notify.fn, but in couple of places
>> it is not done when allocating on stack...
>
> As far as I can see it is initialised where it needs to be.
>
>>       struct dm_io_request io_req = {
>>               ....,
>>               .notify.fn = NULL,
>>       };
>
> (Struct members not listed explicitly are initialised according to the same
> rules used for initialising static variables.  IOW a pointer is initialised
> to NULL.)

oh. indeed.


dm_bufio_issue_flush() uses REQ_FLUSH, but all other places in the
kernel use WRITE_FLUSH...
Should dm_bufio_issue_flush() also use WRITE_FLUSH?

- Dmitry


>
> Alasdair
>
> --
> dm-devel mailing list
> dm-devel redhat com
> https://www.redhat.com/mailman/listinfo/dm-devel