[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH v4 1/2] block: Fix a buffer overrun in bio_integrity_split()



Hey, guys.

On Wed, Oct 24, 2012 at 12:34 PM, Martin K. Petersen
<martin petersen oracle com> wrote:
>>>>>> "Vivek" == Vivek Goyal <vgoyal redhat com> writes:
>
> Vivek> Initially he had reordered the bio_pair fields but there were
> Vivek> couple of issues. We could not assume that there is no padding
> Vivek> between fields and secondly some of the initializtion of looked
> Vivek> plain ugly.
>
> Vivek> IMHO, introduction of bip_vec to fix this issue is small and
> Vivek> cleaner then reordering fields.
>
> I agree.

If Martin is happy with it, I'm not gonna push it but putting the
respective storage member after one containing vararray at the end is
a legit way to allocate the area statically. As long as the storage
field is marked as such and not accessed directly, it doesn't matter
whether there's padding inbetween or not. Anyways, let's push this one
to -stable then.

Thanks.

-- 
tejun


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]