[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH v4 2/2] block: Convert integrity to bvec_alloc_bs()



>>>>> "Kent" == Kent Overstreet <koverstreet google com> writes:

Kent> Also, bio_integrity_alloc() was using fs_bio_set if no bio_set was
Kent> specified. This was wrong

You did that, I didn't.


Kent> - using the bio_set doesn't protect us from memory allocation
Kent>   failures, because we just used kmalloc for the
Kent>   bio_integrity_payload.

I don't understand this comment. kmalloc where?

The bip includes an embedded bvec array and comes from either one of the
dedicated slabs or - in the case of the max bvec size - from a
mempool. These slabs and the mempool are per bio_set.

-- 
Martin K. Petersen	Oracle Linux Engineering


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]