[dm-devel] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

David Laight David.Laight at ACULAB.COM
Thu Sep 6 14:36:52 UTC 2012


> My solution to making 'break' work in the iterator is:
> 
> 	for (bkt = 0, node = NULL; bkt < HASH_SIZE(name) && node ==
NULL; bkt++)
> 		hlist_for_each_entry(obj, node, &name[bkt], member)

I'd take a look at the generated code.
Might come out a bit better if the condition is changed to:
	node == NULL && bkt < HASH_SIZE(name)
you might find the compiler always optimises out the
node == NULL comparison.
(It might anyway, but switching the order gives it a better
chance.)

	David







More information about the dm-devel mailing list