[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix
- From: "Martin K. Petersen" <martin petersen oracle com>
- To: Kent Overstreet <koverstreet google com>
- Cc: axboe kernel dk, "Martin K. Petersen" <martin petersen oracle com>, dm-devel redhat com, linux-kernel vger kernel org, linux-bcache vger kernel org, tj kernel org, Vivek Goyal <vgoyal redhat com>
- Subject: Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix
- Date: Wed, 12 Sep 2012 15:39:18 -0400
>>>>> "Kent" == Kent Overstreet <koverstreet google com> writes:
Kent,
Kent> To fix the bug first, I'd have to reorder struct bio_pair and then
Kent> just delete two lines of code from bio_integrity_split(). But the
Kent> reordering is unnecessary with the refactoring.
Well, a bug is a bug and the fix needs to go into stable. So we will
need a patch that does not depend on your changes.
I don't have a problem with adding a pointer so clones can point to the
parent's vector. But embedding the vector into the bip was a feature.
If you check the git log you'll see that originally I did use separate
vector allocations.
--
Martin K. Petersen Oracle Linux Engineering
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]