[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [dm-devel] [PATCH v10 8/8] block: Add bio_clone_bioset(), bio_clone_kmalloc()
- From: Alasdair G Kergon <agk redhat com>
- To: Kent Overstreet <koverstreet google com>
- Cc: Jens Axboe <axboe kernel dk>, dm-devel redhat com, Jeff Garzik <jeff garzik org>, linux-kernel vger kernel org, linux-bcache vger kernel org, Boaz Harrosh <bharrosh panasas com>, Alasdair Kergon <agk redhat com>
- Subject: Re: [dm-devel] [PATCH v10 8/8] block: Add bio_clone_bioset(), bio_clone_kmalloc()
- Date: Tue, 18 Sep 2012 17:15:29 +0100
On Mon, Sep 17, 2012 at 01:42:27PM -0700, Kent Overstreet wrote:
> Previously, it was open coding __bio_clone(), that's what the setting
> bi_idx to 0 was from. With the change to bio_clone_bioset() that's no
> longer necessary (and dangerous, since bi_idx needs to be consistent
> with bi_sector/bi_size).
It was performing a partial clone, deleting any no-longer-needed entries
from the array. This patch undoes that which is presumably OK because
you propose to eliminate them again in a later one of your patches.
Alasdair
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]