[dm-devel] [PATCH] dm-lc.c: fix for a potential NULL pointer dereference

Kumar Amit Mehta gmate.amit at gmail.com
Wed Jul 31 12:09:28 UTC 2013


Memory allocation may fail, hence add a check before dereferencing
the pointer.

Signed-off-by: Kumar Amit Mehta <gmate.amit at gmail.com>
---
 Driver/dm-lc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Driver/dm-lc.c b/Driver/dm-lc.c
index 4a65042..e00fb27 100644
--- a/Driver/dm-lc.c
+++ b/Driver/dm-lc.c
@@ -2671,6 +2671,8 @@ static int lc_mgr_message(struct dm_target *ti, unsigned int argc, char **argv)
 	 */
 	if (!strcasecmp(cmd, "resume_cache")) {
 		struct lc_cache *cache = kzalloc(sizeof(*cache), GFP_KERNEL);
+		if (!cache)
+			return -ENOMEM;
 
 		struct dm_dev *dev;
 		if (dm_get_device(ti, argv[1], dm_table_get_mode(ti->table),
-- 
1.8.3.1




More information about the dm-devel mailing list