[dm-devel] [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

Paul Taysom taysom at google.com
Mon Mar 4 21:23:54 UTC 2013


On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon <agk at redhat.com> wrote:
> On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote:
>> @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, struct dm_verity_io *io)
>>                               hash_block_end = v->hash_blocks - 1;
>>               }
>>  no_prefetch_cluster:
>> -             dm_bufio_prefetch(v->bufio, hash_block_start,
>> -                               hash_block_end - hash_block_start + 1);
>> +             vw = kmalloc(sizeof(*vw), GFP_KERNEL);
>
> kmalloc?  mempool? ...
>
> Alasdair
>
The use of mempool would be a separate patch that would have to be
measured for performance impact.
-Paul




More information about the dm-devel mailing list