[dm-devel] [PATCH 3/3] Library with an exit()
Bart Van Assche
bvanassche at acm.org
Sun Mar 9 12:27:21 UTC 2014
On 03/09/14 12:56, Ritesh Raj Sarraf wrote:
> Signed-off-by: Ritesh Raj Sarraf <rrs at debian.org>
> ---
> libmpathpersist/mpath_persist.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/libmpathpersist/mpath_persist.c b/libmpathpersist/mpath_persist.c
> index bd30125..6b6901e 100644
> --- a/libmpathpersist/mpath_persist.c
> +++ b/libmpathpersist/mpath_persist.c
> @@ -585,11 +585,12 @@ int send_prout_activepath(char * dev, int rq_servact, int rq_scope,
> rc = pthread_create(&thread, &attr, mpath_prout_pthread_fn, (void *)(¶m));
> if (rc){
> condlog (3, "%s: failed to create thread %d", dev, rc);
> - exit(-1);
> }
> - /* Free attribute and wait for the other threads */
> - pthread_attr_destroy(&attr);
> - rc = pthread_join(thread, NULL);
> + else {
> + /* Free attribute and wait for the other threads */
> + pthread_attr_destroy(&attr);
> + rc = pthread_join(thread, NULL);
> + }
>
> return (param.status);
> }
pthread_attr_destroy() should also be called if pthread_create() fails.
Bart.
More information about the dm-devel
mailing list