[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Are we building against CentOS 5.2 or 5.1



On Fri, 18 Jul 2008 11:44:00 +0200, Michael Schwendt wrote:

> > Just so I don't mailbomb everyone again.  Changing:
> > 
> > process_deps 5 i386 testing yes
> > 
> > to
> > 
> > process_deps 5 i686 testing yes
> > 
> > ?
> 
> Ah, no, I forgot that somebody added that stuff. In the context of
> process_deps this additional line near the top, where a similar thing
> is done for ppc, would be needed (I only see a diff of a script called
> checkEpel.sh):
> 
>     [ $arch == "i386" ] && arch_label=i686 || arch_label=$arch

As the 'OR' is troublesome, it ought to be dropped in favour of giving
$arch_label a default value earlier. Top of function should look like this:

process_deps()
{
    release=$1
    arch=$2
    testing=$3
    mail=$4
    [ -z $4 ] && mail="no" || mail="yes"
-    [ $arch = "ppc" ] && arch_label=ppc64 || arch_label=$arch
+    arch_label=$arch
+    [ $arch == "i386" ] && arch_label=i686
+    [ $arch == "ppc" ] && arch_label=ppc64
    command="/usr/local/bin/rc-modified -d mdcache -n -c $YUM_CONF_LOC -a 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]