[et-mgmt-tools] [PATCH] Fix lookup pool by path
Cole Robinson
crobinso at redhat.com
Wed Dec 3 16:21:47 UTC 2008
Andreas Schneider wrote:
> On Monday 01 December 2008 16:07:45 Cole Robinson wrote:
>> Hmm, so your pool xml lists the target directory with a trailing slash?
>> I'm not seeing that. What version of libvirt are you using, and can you
>> provide the pools xml?
>
> Hi,
>
> I'm using virt-manager to connect to a remote host, so if I create a pool I
> have to specify the path to the pool manually.
>
> This means you can enter as many trailing slashes as you want. So the
> questions is, should the slashes be stripped during the creation of the pool
> too?
>
> <pool type='dir'>
> <name>tmp</name>
> <uuid>17e0c17a-3cd3-bc20-f1bc-7c9ffaceb255</uuid>
> <capacity>0</capacity>
> <allocation>0</allocation>
> <available>0</available>
> <source>
> </source>
> <target>
> <path>/var/lib/libvirt/images/tmp/////</path>
> <permissions>
> <mode>0700</mode>
> <owner>0</owner>
> <group>0</group>
> </permissions>
> </target>
> </pool>
>
Hmm, yes, seems like libvirt should be sanitizing the target path when
the pool is defined (though virtinst could certainly do this too).
Looks like there could be arbitrary '/' in the middle of the path
though, so if you use something like os.path.abspath in your patch it
should sanitize everything appropriately.
Thank,
Cole
More information about the et-mgmt-tools
mailing list