rpms/module-init-tools/FC-4 module-init-tools-badmodule.patch, NONE, 1.1 module-init-tools.spec, 1.10, 1.11

[fedora-cvs-commits redhat com]

Author: notting

Update of /cvs/dist/rpms/module-init-tools/FC-4
In directory cvs.devel.redhat.com:/tmp/cvs-serv29197

Modified Files:
	module-init-tools.spec 
Added Files:
	module-init-tools-badmodule.patch 
Log Message:
fix segfault on bad modules (#162716)


module-init-tools-badmodule.patch:
 moduleops_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- NEW FILE module-init-tools-badmodule.patch ---
--- module-init-tools-3.1/moduleops_core.c.foo	2005-07-22 17:01:24.000000000 -0400
+++ module-init-tools-3.1/moduleops_core.c	2005-07-22 17:02:01.000000000 -0400
@@ -92,6 +92,8 @@
 	strings = PERBIT(load_section)(module->data, ".strtab", &size);
 	syms = PERBIT(load_section)(module->data, ".symtab", &size);
 
+	module->num_deps = 0;
+	module->deps = NULL;
 	if (!strings || !syms) {
 		warn("Couldn't find symtab and strtab in module %s\n",
 		     module->pathname);
@@ -104,8 +106,6 @@
 	    hdr->e_machine == EM_SPARCV9)
 		handle_register_symbols = 1;
 
-	module->num_deps = 0;
-	module->deps = NULL;
 	for (i = 1; i < size / sizeof(syms[0]); i++) {
 		if (syms[i].st_shndx == SHN_UNDEF) {
 			/* Look for symbol */


Index: module-init-tools.spec
===================================================================
RCS file: /cvs/dist/rpms/module-init-tools/FC-4/module-init-tools.spec,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- module-init-tools.spec	25 Apr 2005 16:42:24 -0000	1.10
+++ module-init-tools.spec	22 Jul 2005 21:06:29 -0000	1.11
@@ -8,6 +8,7 @@
 Source1: http://ftp.kernel.org/pub/linux/utils/kernel/module-init-tools/module-init-tools-%{version}.tar.bz2.sign
 Source2: modprobe.conf.dist
 Patch1: module-init-tools-defconfig.patch
+Patch2: module-init-tools-badmodule.patch
 Exclusiveos: Linux
 Prereq: /sbin/chkconfig sh-utils
 Obsoletes: modules modutils-devel modutils
@@ -24,6 +25,7 @@
 %prep
 %setup -q -n module-init-tools-%{version}
 %patch1 -p1 -b .dist
+%patch2 -p1 -b .boom
 
 %build
 export CFLAGS="-Os -g -DCONFIG_NO_BACKWARDS_COMPAT=1"
@@ -81,6 +83,9 @@
 %{_mandir}/*/*
 
 %changelog
+* Fri Jul 22 2005 Bill Nottingham <notting redhat com> 3.1-4
+- fix depmod segfault on bad modules (#162716)
+
 * Mon Apr 25 2005 Bill Nottingham <notting redhat com> 3.1-3
 - load snd-seq-device/snd-seq-oss on load of pcm devices (part of #147637)