rpms/sysstat/FC-6 sysstat-7.0.0-cve_2007_3852.patch, NONE, 1.1 sysstat.spec, 1.46, 1.47

[fedora-cvs-commits at redhat.com]

Author: varekova

Update of /cvs/dist/rpms/sysstat/FC-6
In directory cvs.devel.redhat.com:/tmp/cvs-serv17914

Modified Files:
	sysstat.spec 
Added Files:
	sysstat-7.0.0-cve_2007_3852.patch 
Log Message:
- fix cve-2007-3852 -
  sysstat insecure temporary file usage


sysstat-7.0.0-cve_2007_3852.patch:
 sysstat.in |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

--- NEW FILE sysstat-7.0.0-cve_2007_3852.patch ---
--- sysstat-7.0.0/sysstat.in.pom	2007-08-20 12:02:24.000000000 +0200
+++ sysstat-7.0.0/sysstat.in	2007-08-20 12:26:21.000000000 +0200
@@ -27,22 +27,21 @@
 #
 
 RETVAL=0
-# Remove flag indicating that sadc was successfully launched
-rm -f /tmp/sysstat.run
 
 # See how we were called.
 case "$1" in
   start)
+	exitCodeIndicator="$(mktemp /tmp/sysstat-XXXXXX)" || exit 1
         echo -n "Calling the system activity data collector (sadc): "
-        SU SA_LIB_DIR/sadc -F -L - && touch /tmp/sysstat.run QUOTE
+        SU SA_LIB_DIR/sadc -F -L - || rm -f ${exitCodeIndicator} QUOTE
 
 # Try to guess if sadc was successfully launched. The difficulty
 # here is that the exit code is lost when the above command is
 # run via "su foo -c ..."
-	if [ ! -f /tmp/sysstat.run ]; then
-		RETVAL=1
+	if [ -f "${exitCodeIndicator}" ]; then
+		rm -f ${exitCodeIndicator}
 	else
-		rm -f /tmp/sysstat.run
+		RETVAL=1
 	fi
         echo
         ;;


Index: sysstat.spec
===================================================================
RCS file: /cvs/dist/rpms/sysstat/FC-6/sysstat.spec,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -r1.46 -r1.47
--- sysstat.spec	22 Jan 2007 09:27:28 -0000	1.46
+++ sysstat.spec	20 Aug 2007 10:32:56 -0000	1.47
@@ -1,6 +1,6 @@
 Name: sysstat
 Version: 7.0.0
-Release: 4%{?dist}
+Release: 5%{?dist}
 Summary: The sar and iostat system monitoring commands.
 License: GPL
 Group: Applications/System
@@ -16,6 +16,7 @@
 Patch8: sysstat-7.0.0-nfs.patch
 Patch9: sysstat-7.0.0-nfs2.patch
 Patch10: sysstat-7.0.0-realloc.patch
+Patch11: sysstat-7.0.0-cve_2007_3852.patch
 
 BuildRoot: %{_tmppath}/%{name}-%{version}-root
 
@@ -38,6 +39,7 @@
 %patch8 -p1 -b .nfs
 %patch9 -p1 -b .nfs2
 %patch10 -p1 -b .realloc
+%patch11 -p1 -b .cve3852
 
 %build
 # FIXME: I need to fix the upstream Makefile to use LIBDIR et al. properly and
@@ -117,6 +119,10 @@
 /var/log/sa
 
 %changelog
+* Mon Aug 20 2007 Ivana Varekova <varekova at redhat.com> - 7.0.0-5
+- fix cve-2007-3852 -
+  sysstat insecure temporary file usage
+
 * Mon Jan 22 2007 Ivana Varekova <varekova at redhat.com> - 7.0.0-4
 - Resolves: 223566 
   sysstat complains "realloc: Success"