On Fri, Feb 06, 2004 at 09:27:23PM +0000, Gavin Henry wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Dear all,
>
> I know everyone is extremely busy, but if someone has time to check over my
> first spec file and give me some feedback/pointers, it would be greatly
> appreciated.
>
> It was made with Mach and installs on FC1 and RH9 fine.
>
> Thanks,
>
> Gavin.
>
> url: http://www.suretecsystems.com/docs/netmon_applet.spec
>
>
A few comments:
> Source0 : http://www.demonseed.net/~jp/code/netmon_applet/netmon_applet-0.4.tar.gz
It's better to use %{version} here. Otherwise you'd have to change the version
at two places when you update to p.e. 0.5
>BuildRoot : %{_tmppath}/%{name}-{buildroot}
Missing % ? ^
>./configure \
> --libdir=%{_libdir} \
> --bindir=%{_bindir} \
> --datadir=%{_datadir} \
> --sysconfdir=%{_sysconfdir}
Use %configure, this sets those parameters automatically. Check
/usr/lib/rpm/macros so see the complete %configure macro.
Karsten
--
Karsten Hopp | Mail: karsten redhat de
Red Hat Deutschland | Tel: +49-711-96437-0
Hauptstaetterstr.58 | Fax: +49-711-96437-111
D-70178 Stuttgart | http://www.redhat.de
Attachment:
pgp00045.pgp
Description: PGP signature