Re: Patch for Keyspan USB-serial adapter...

[Pete Zaitcev <zaitcev redhat com>]

On Wed, 21 Jan 2004 22:39:10 -0600
Randy Zagar <jrzagar cactus org> wrote:

> The attached patch files include changes to the kernel-2.4.spec file and
> a patch file from the vendor:
> 
>     http://www.keyspan.com/support/linux/files/currentversion/patch/

I always turn such things down unless there's an overriding reason to
include them. Every patch, no matter how correct or benign, adds maintenance
burden. IMHO, it is even more justified in case of Fedora, because of
Fedora's short release cycle.

The correct way to handle this patch is
 1) to identify a champion for the issue. Sometimes it's a user, but
    often a vendor. If Keyspan cannot be arsed to
    perform the rest of the steps, users have to step in.
 2) to file upstream, in this case linux-usb-devel
 3) track the rest

I can fill in as a champion for many issues USB, but not all.
If I had the hardware, I might have.

The patches appear to be a backport of what is present in 2.6 already,
so there should not be a problem passing linux-usb-devel and Greg Kroah.

-- Pete