Console user mount patch and FC3
John (J5) Palmieri
johnp at redhat.com
Thu Sep 30 17:33:53 UTC 2004
On Thu, 2004-09-30 at 12:20 -0400, Alan Cox wrote:
> On Thu, Sep 30, 2004 at 11:59:37AM -0400, John (J5) Palmieri wrote:
> > This is in reference to RH bug#133941. It is suggested I take this
> > discussion to fedora-devel. What is keeping this patch out of FC3? I
>
> Had a quick look. It contains an obvious missing null pointer check. Would
> also need security review against pam_console and an explanation of why
> it relies on pam_console innards (paths etc)
>
> > turn on this option after install. I have looked at the patch and it is
> > simple and does matching the same way we do it in dbus. Getting this
>
> If dbus is using getusername() I hope it to is considering NULL pointer
> cases. I'd also like to know it is grovelling in pam related innards - do
> we in fact need a libconsole library to wrap this from pam and utility sides ?
>
> Alan
Issue is fixed in new patch.
--
John (J5) Palmieri
Associate Software Engineer
Desktop Group
Red Hat, Inc.
Blog: http://martianrock.com
More information about the fedora-devel-list
mailing list