[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: short koji repo question



On Thu, 2007-10-04 at 13:40 +0200, Oliver Falk wrote:
> Well. Sooner or later you'll have sqlite support for createrepo on your
> machines and then:
> 
> --- /usr/sbin/kojid     2007-10-04 13:36:32.000000000 +0200
> +++ /tmp/kojid  2007-10-04 13:36:15.000000000 +0200
> @@ -2244,7 +2244,7 @@
>          outdir = "%s/repo" % self.workdir
>          datadir = "%s/repodata" % outdir
>          koji.ensuredir(outdir)
> -        cmd = ['/usr/bin/createrepo', '-vpd', '--outputdir', outdir]
> +        cmd = ['/usr/bin/createrepo', '-vp', '--outputdir', outdir]
>          if os.path.exists("%s/comps.xml" % repodir):
>              cmd.extend(['-g', 'comps.xml'])
>          #attempt to recycle repodata from last repo
> @@ -2272,7 +2272,7 @@
> 
>          files = []
>          for f in os.listdir(datadir):
> -            if f.endswith('.xml') or f.endswith('.xml.gz') or
> f.endswith('.bz2'):
> +            if f.endswith('.xml') or f.endswith('.xml.gz'):
>                  files.append(f)
>                  session.uploadWrapper("%s/%s" % (datadir, f),
> uploadpath, f)
> 
> 
> I can do more digging and check if I can add some config key and >if<
> that two lines of code... Or we simply check which version of createrepo
> introduced -d and BR it in koji spec...
> 
> I can also open a ticket on hosted, if you prefer!?
> 
> Best,
>  Oliver
> 

I think your patch is backward.  Shouldn't the -'s be +'s and visa
versa?

Jonathan

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]