[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rpms/rpcbind/devel rpcbind.init,1.7,1.8 rpcbind.spec,1.21,1.22



On Tue, 16 Oct 2007 12:12:26 -0400, Steve Dickson (steved) wrote:

> Author: steved
> 
> Update of /cvs/pkgs/rpms/rpcbind/devel
> In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv31038
> 
> Modified Files:
> 	rpcbind.init rpcbind.spec 
> Log Message:
> Corrected a typo in the initscript from previous commit.

>  	# Check that networking is up.
> -	[ "$NETWORKING" = "no" ] || exit 6
> +	[ "$NETWORKING" = "no" ] && exit 6
>  	[ -f /sbin/$prog ] || exit 5

Isn't

	[ "$NETWORKING" = "yes" ] || exit 6

preferred, so the service is off by default unless networking
is turnt on explicitly?

You already do

	if [ -f /etc/sysconfig/network ]; then
		. /etc/sysconfig/network
	else
		exit 6
	fi

which means that a missing definition of $NETWORKING in an
empty /etc/sysconfig/network would not cause the rpcbind service
script to exit 6.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]