rpmlint message '%ifarch-applied-patch'

[Richard W.M. Jones]

Ralf Corsepius wrote:
> On Wed, 2007-09-19 at 14:10 +0200, Jindrich Novy wrote:
>> Hi,
>>
>> On Wed, Sep 19, 2007 at 01:04:18PM +0100, Richard W.M. Jones wrote:
>>> What does this rpmlint message mean?  I don't understand why it's harmful 
>>> to have patches only applying to particular architectures.
>>>
>>> -----
>>>
>>> ical.src: W: %ifarch-applied-patch Patch3: ical-2.2-ia64.patch
>>> A patch is applied inside an %ifarch block. Patches must be applied
>>> on all architectures and may contain necessary configure and/or code
>>> patch to be effective only on a given arch.
>>>
>>> -----
>> It likely means that you have a construct like this in a spec file:
>>
>> %ifarch x86_64
>> Patch1: some.patch
>> %endif
> 
> Besides this, this patch seems rather silly to me.
> 
> Instead of trying to mess around with local defs of gethostname(),
> you should probably better "#include <unistd.h>".
> 
> Ralf
> 
> PS.:  __linux__ is the correct (POSIX-compliant) define to identify
> linux.

This code is ancient history anyway.  Development on ical was 
_abandoned_ around 1994.

https://bugzilla.redhat.com/show_bug.cgi?id=296161

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-devel-list/attachments/20070919/9d76b569/attachment.bin>