zombie packages.

[Mamoru Tasaka]

Rahul Bhalerao wrote, at 02/24/2008 07:45 PM +9:00:
> On Sun, Feb 24, 2008 at 6:47 AM, Dave Jones <davej at redhat.com> wrote:
>> On Sat, Feb 23, 2008 at 08:25:22PM +0530, Rahul Sundaram wrote:
>>   > Dave Jones wrote:
>>   >
>>   > >
>>   > > sarai-fonts
>>   > > date: 2008/02/18 20:17:04;  author: kevin;  state: Exp;
>>   > > Setup of module sarai-fonts
>>   >
>>   > The CVS admin work was done but I just build this package for all
>>   > branches. Should be ok now.
>>
>>  It's %prep is totally busted.  It seems to think that SOURCEDIR==BUILDDIR
>>  resulting in this..
>>
>>  + cp /mnt/raid0/src/devel-co/sarai-fonts/COPYING .
>>  cp: `/mnt/raid0/src/devel-co/sarai-fonts/COPYING' and `./COPYING' are the same file
>>  error: Bad exit status from /var/tmp/rpm-tmp.10761 (%prep)
>>
>>  How did this get past package review?
>>
> 
> The review was done by me(my first review). I am unable to understand
> this problem. The mock build
> (http://koji.fedoraproject.org/koji/taskinfo?taskID=431692) did not
> have any problem. Even the final build is shown successful
> (http://koji.fedoraproject.org/koji/buildinfo?buildID=39609).
> 
> I think the spec template for font packages should have some more info
> about the %prep section. A  similar %prep used in madan-fonts did not
> have such problem.
> 
> May I get a help on this?
> 
> Thanks,
> Rahul.


The failure Dave saw can be reproduced by
$ export CVSROOT=:ext:<username>@cvs.fedora.redhat.com:/cvs/extras
$ export CVS_RSH=ssh
$ cvs co sarai-fonts
$ cd sarai-fonts/devel
$ make i386

In this case "make i386" does something like:
[tasaka1 at localhost devel]$ LANG=C make i386
rpmbuild --define "_sourcedir /home/tasaka1/rpmbuild/fedora-specific/sarai-fonts/devel" --define "_specdir /home/tasaka1/rpmbuild/fedora-specific/sarai-fonts/devel" --define "_builddir /home/tasaka1/rpmbuild/fedora-specific/sarai-fonts/devel" --define "_srcrpmdir /home/tasaka1/rpmbuild/fedora-specific/sarai-fonts/devel" --define "_rpmdir /home/tasaka1/rpmbuild/fedora-specific/sarai-fonts/devel" --define "dist .fc9" --define "fedora 9" --target i386 -ba sarai-fonts.spec 2>&1 | tee .build-1.0-3.fc9.log ; exit ${PIPESTATUS[0]}
Building target platforms: i386
Building for target i386
Executing(%prep): /bin/sh -e /home/tasaka1/rpmbuild/INSTROOT/rpm-tmp.10146
+ umask 022
+ cd /home/tasaka1/rpmbuild/fedora-specific/sarai-fonts/devel
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cp -p /home/tasaka1/rpmbuild/fedora-specific/sarai-fonts/devel/COPYING .
cp: `/home/tasaka1/rpmbuild/fedora-specific/sarai-fonts/devel/COPYING' and `./COPYING' are the same file
error: Bad exit status from /home/tasaka1/rpmbuild/INSTROOT/rpm-tmp.10146 (%prep)

Here _sourcedir and _builddir is same. In this case the failure happens.
In short, %setup is missing. sarai-fonts spec file should be:

%prep
%setup -q -T -c
cp -p %{SOURCE1} .

%build
......

Regards,
Mamoru