[PATCH] Speed up modprobe and MAKEDEV

Jakub Jelinek jakub at redhat.com
Mon Oct 13 14:10:01 UTC 2008


On Mon, Oct 13, 2008 at 09:52:17AM -0400, Jon Masters wrote:
> On Wed, 2008-10-01 at 13:20 -0400, Kyle McMartin wrote:
> > On Wed, Oct 01, 2008 at 06:52:15PM +0200, Jakub Jelinek wrote:
> > > Given the recent 5sec boot efforts http://lwn.net/Articles/299483/
> > > and Mandriva follow-ups on that http://lwn.net/Articles/300873/,
> > > I thought I'd share my modprobe and MAKEDEV speedup patches with
> > > a wider community so folks can experiment with them, especially seeing
> > > Mandriva folks playing with turning modprobe into a daemon because of its
> > > slowness.
> 
> > Have you tested things on a big endian machine? In any case, this looks
> > really good. Hopefully Jon will apply this upstream soon so we can get
> > it in F10.
> 
> So I've added an alternative patch from Alan Jenkins to the current git
> and in rawhide today, also using a binary index (there's no version info
> embedded right now however that is about to be fixed in a later patch).
> I think my plan right now is to profile this against Jakub's patch and
> pick the winner. So there might be a few more changes this week :)

FYI, here is a tiny incremental fix for the patch I've posted earlier
- Mandriva folks reported that with my patch depmod was upset when run
on a tree with no modules at all.
--- module-init-tools-3.4.1/depmod.c	2008-10-01 17:32:14.000000000 +0200
+++ module-init-tools-3.4.1/depmod.c	2008-10-07 11:49:29.000000000 +0200
@@ -651,6 +651,8 @@
 			d = d->next;
 		}
 	}
+	if (strings->dir0.len == -1)
+		strings->dir0.len = 0;
 no_dir0:;
 	/* Assign the remaining up to 255 directory table
 	   entries, starting with most often used ones.  */


	Jakub




More information about the fedora-devel-list mailing list