[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

rt2860 driver (fc11)



I know this is a staging and thus experimental driver.
I only wanted to point out that if you compile the kernl 
without SMP support, then this driver module will have these
undefined symbols:

spin_lock_bh
_per_cpu_offset
synchronize_irq
spin_unlock_irqrestore
del_timer_sync
spin_lock_irqsave

I did a cursory look at part of the code, and it is obvious
this code is not up to snuff in coding style, and in one file, missing 
header include.
At the very least, the code needs to surround locking
and unlocking code with 
#ifdef CONFIG_SMP
   spin_lock...    or spin_unlock ...
#endif

My $.02's worth

Cheers,

Markus K.

_________________________________________________________________
Get back to school stuff for them and cashback for you.
http://www.bing.com/cashback?form=MSHYCB&publ=WLHMTAG&crea=TEXT_MSHYCB_BackToSchool_Cashback_BTSCashback_1x1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]