[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

RE: rt2860 driver (fc11)





----------------------------------------
> From: awilliam redhat com
> To: fedora-devel-list redhat com
> Date: Wed, 5 Aug 2009 23:27:32 -0700
> Subject: Re: rt2860 driver (fc11)
>
> On Wed, 2009-08-05 at 21:58 -0700, Markus Kesaromous wrote:
>> I know this is a staging and thus experimental driver.
>> I only wanted to point out that if you compile the kernl
>> without SMP support, then this driver module will have these
>> undefined symbols:
>>
>> spin_lock_bh
>> _per_cpu_offset
>> synchronize_irq
>> spin_unlock_irqrestore
>> del_timer_sync
>> spin_lock_irqsave
>>
>> I did a cursory look at part of the code, and it is obvious
>> this code is not up to snuff in coding style, and in one file, missing
>> header include.
>> At the very least, the code needs to surround locking
>> and unlocking code with
>> #ifdef CONFIG_SMP
>> spin_lock... or spin_unlock ...
>> #endif
>
> Wouldn't this be better sent to lkml? I don't think anyone in Fedora
> works on the in-kernel rt2860 driver, do they? I don't recognize any of
> the names in
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;f=drivers/staging/rt2860;hb=HEAD as being 'Fedora people'.
>
> --
> Adam Williamson
> Fedora QA Community Monkey
> IRC: adamw | Fedora Talk: adamwill AT fedoraproject DOT org
> http://www.happyassassin.net
>
> --
> fedora-devel-list mailing list
> fedora-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/fedora-devel-list

I was hoping that the devs who worked hard to even make it part of the source rpm might be lurking on this mailing list and see my post :)


_________________________________________________________________
Express your personality in color! Preview and select themes for HotmailĀ®. 
http://www.windowslive-hotmail.com/LearnMore/personalize.aspx?ocid=PID23391::T:WLMTAGL:ON:WL:en-US:WM_HYGN_express:082009


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]