[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: pulseaudio 0.9.15 for F10?



Lennart Poettering wrote:
> On Sat, 08.08.09 12:10, Roberto Ragusa (mail robertoragusa it) wrote:
> 
> I am certainly one of those people who think that released
> distributions should only receive security fixes and small other bug
> fixes.

I am one of those people who think supported distributions
should receive fixes.
Kudos to the KDE guys who go beyond small fixes and actually push
KDE 4.3 to F10.

> Upgrading PA like this involves big changes and does not qualify as
> either security nor as small other bug fixes.
> 
> If you want a newer PA I'd recommend doing the upgrade from F10 to F11.

Not a good reason to upgrade.

Actually I don't want a newer PA, just a working PA.
So, I backported the patch myself.

After applying this patch, mplayer does not get stuck, it is just the usual
latency/skips/underruns...


diff -urN pulseaudio-0.9.14/src/pulsecore/protocol-native.c pulseaudio-0.9.14-fix440/src/pulsecore/protocol-native.c
--- pulseaudio-0.9.14/src/pulsecore/protocol-native.c   2009-01-13 00:11:38.000000000 +0100
+++ pulseaudio-0.9.14-fix440/src/pulsecore/protocol-native.c    2009-08-08 18:46:34.000000000 +0200
@@ -797,7 +797,7 @@
         uint32_t* prebuf,
         uint32_t* minreq) {

-    size_t frame_size;
+    size_t frame_size, max_prebuf;
     pa_usec_t orig_tlength_usec, tlength_usec, orig_minreq_usec, minreq_usec, sink_usec;

     pa_assert(s);
@@ -923,8 +923,10 @@
     if (*tlength <= *minreq)
         *tlength = *minreq*2 + (uint32_t) frame_size;

-    if (*prebuf == (uint32_t) -1 || *prebuf > *tlength)
-        *prebuf = *tlength;
+    max_prebuf = *tlength + (uint32_t) frame_size - *minreq;
+    if (*prebuf == (uint32_t) -1 ||
+        *prebuf > max_prebuf)
+        *prebuf = max_prebuf;
 }

 static void fix_playback_buffer_attr_post(


-- 
   Roberto Ragusa    mail at robertoragusa.it


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]