[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Catching python syntax errors at build time



On Friday, February 20 2009, Daniel P. Berrange said:
> On Fri, Feb 20, 2009 at 05:36:30PM +0000, Tim Waugh wrote:
> > It occurred to me that, since we are already byte-compiling Python code 
> > at build time, it is no extra effort to verify that it can be parsed and 
> > fail if not.
> > 
> > See attached patch.
> > 
> > Can anyone think of any reason not to do this?
> 
> If it catches things like the python syntax error in anaconda for today's
> rawhide compose, that makes installs impossible, then it is well worth it

Yeah, I'm for putting it in.  While it may cause a couple more
speed-bumps for the rebuild next week, it'll raise our quality in the
long run and therefore seems like the "right" thing to do

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]