[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: RFC: proposed macro deffinitions for F-13



On Tuesday 27 October 2009 12:45:10 pm Eric Sandeen wrote:
> Dennis Gilmore wrote:
> > Hi All,
> >
> > Id like to get some feedback on the patches that i'm proposing for F-13.
> > quite a few packages that need to deal with differences between
> > 32bit/64bit  or multilib arches have defines for the appropriate arches. 
> > sometimes incomplete since they don't include secondary arches.
> >
> > I wanted to get some feedback. and see if there are other cases we should
> > add.
> >
> > Dennis
> 
> I have hacks like this in e2fsprogs.spec for example:
> 
> 
> %ifarch %{multilib_arches}
> mv -f %{buildroot}%{_includedir}/ext2fs/ext2_types.h \
>       %{buildroot}%{_includedir}/ext2fs/ext2_types-%{_arch}.h
> install -p -m 644 %{SOURCE1} %{buildroot}%{_includedir}/ext2fs/ext2_types.h
> %endif
> 
> Unless I'm doing a Bad Thing here, maybe some macros to facilitate this
> type of header mangling for multiarch?

right now you need to define multilib_arches for that to work with my proposed 
changes you could drop your defines  and use 
%ifarch %{multilib64} %{multilib32}

maybe we want to define a multilibarches macro also   that way if/when we add a 
new multilib arch. we make one changes and rebuild everything and we support 
it. rather than changing potentially hundresd of spec files.  of course they 
will need to be changed to use the new macros.


Dennis

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]