Re: packages for review: openbox and friends

[Adrian Reber <adrian lisas de>]

> <http://www.oobleck.net/kaboom/fedora/srpms/openbox-3.2-3.src.rpm>

There are errors when trying to build it with mach:

checking for glib-2.0... Package glib-2.0 was not found in the
pkg-config search path.
Perhaps you should add the directory containing `glib-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'glib-2.0' found

configure: error: Library requirements (glib-2.0) not met; consider
adjusting the PKG_CONFIG_PATH environment variable if your libraries are
in a nonstandard prefix so pkg-config can find them.
error: Bad exit status from /var/tmp/rpm-tmp.68474 (%build)

You need to add glib2-devel, libxml2-devel and
startup-notification-devel as BuildRequires and can then remove the
XFree86-devel BR because that will be pulled in by
startup-notification-devel. The same is true for fontconfig-devel as it
is pulled in by xorg-x11-devel:

BuildRequires: bison libxml2-devel
BuildRequires: startup-notification-devel glib2-devel

%post and %postun could be %post(un) -p /sbin/ldconfig and you can then
remove Requires(post(un)): /sbin/ldconfig

I have seen in other reviews that install should use the -p flag to
preserve timestamps. And maybe you could use either cp or install and
not mix it. But that is up to you.

		Adrian

-- 
Adrian Reber <adrian lisas de>            http://lisas.de/~adrian/
Mommy, what happens to your files when you die?