Re: Request for review: perl-BerkeleyDB

[Paul Howarth <paul city-fan org>]

On Sat, 2005-07-30 at 17:43 -0500, Steven Pritchard wrote:
> This is a requirement for amavisd-new:
> 
>   http://ftp.kspei.com/pub/steve/rpms/perl-BerkeleyDB-0.26-1.src.rpm
>   http://ftp.kspei.com/pub/steve/rpms/perl-BerkeleyDB/

Good:

- package name obviously correct
- spec file name correct
- license correct
- tarball md5sum matches upstream
- package builds fine on FC4, and in mock for FC5
- no locale data to worry about
- no shared libraries to worry about
- no duplicate files
- clean section present and correct
- package contains code, not content
- no large documentation files
- docs don't affect running of code
- no header files, libraries or pkgconfig files to worry about
- no scriptlets or subpackages to worry about


Bad:

Package description missing. I suggest:
BerkeleyDB is a module that allows Perl programs to make use of the
facilities provided by Berkeley DB. Berkeley DB is a C library that
provides a consistent interface to a number of database formats.
BerkeleyDB provides an interface to all four of the database types
(hash, btree, queue and recno) currently
supported by Berkeley DB.

Wrong permissions on documentation. Add to %prep:
%{__chmod} -x Changes README

Optflags missing from %build:
%{__make} %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"

For discussion:

The files list results in the package owning %{perl_vendorarch}/auto;
not sure if that's a good idea. I'd be inclined to replace:
%{perl_vendorarch}/*
with:
%{perl_vendorarch}/BerkeleyDB*
%{perl_vendorarch}/auto/BerkeleyDB

Add BR: perl(Test::Pod) and perl(MLDBM) for better test coverage.

Patch to spec attached. If you apply that, I'll approve.

Paul.
-- 
Paul Howarth <paul city-fan org>

--- perl-BerkeleyDB.spec	2005-08-01 18:25:03.000000000 +0100
+++ perl-BerkeleyDB.spec	2005-08-01 18:49:08.000000000 +0100
@@ -2,26 +2,32 @@
 
 Name:           perl-BerkeleyDB
 Version:        0.26
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        BerkeleyDB Perl module
 License:        GPL or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/BerkeleyDB/
 Source0:        http://www.cpan.org/modules/by-module/BerkeleyDB/BerkeleyDB-0.26.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildRequires:  db4-devel
+BuildRequires:  db4-devel, perl(MLDBM), perl(Test::Pod)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
 %description
+BerkeleyDB is a module that allows Perl programs to make use of the facilities
+provided by Berkeley DB. Berkeley DB is a C library that provides a consistent
+interface to a number of database formats. BerkeleyDB provides an interface to
+all four of the database types (hash, btree, queue and recno) currently
+supported by Berkeley DB.
 
 %prep
 %setup -q -n BerkeleyDB-%{version}
 %{__perl} -pi -e 's,/local/,/, if ($. == 1)' dbinfo
+%{__chmod} -x Changes README
 
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
 %{__perl} -pi -e 's/^\tLD_RUN_PATH=[^\s]+\s*/\t/' Makefile
-make %{?_smp_mflags}
+make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"
 
 %install
 rm -rf $RPM_BUILD_ROOT
@@ -45,11 +51,19 @@
 %files
 %defattr(-,root,root,-)
 %doc Changes README Todo
-%{perl_vendorarch}/*
+%{perl_vendorarch}/BerkeleyDB*
+%{perl_vendorarch}/auto/BerkeleyDB
 %{_mandir}/man3/*
 %{_bindir}/*
 
 %changelog
+* Mon Aug  1 2005 Paul Howarth <paul city-fan org> - 0.26-2
+- add BR: perl(MLDBM), perl(Test::Pod) for better test coverage
+- add description
+- fix documentation permissions
+- use $RPM_OPT_FLAGS
+- don't own everything
+
 * Wed Jul 06 2005 Steven Pritchard <steve kspei com> 0.26-1
 - Specfile autogenerated.
 - Add BuildRequires db4-devel.