On Tue, 2005-08-02 at 11:04 -0500, Tom 'spot' Callaway wrote: > On Mon, 2005-08-01 at 21:19 -0400, joel reed wrote: > > > hmm, no feedback this time. can i assume they are now acceptable? > > No, don't assume that. > > In an initial look, I notice a couple of things. > > - You really should consider using some newlines in the spec file. It > significantly helps legibility if you break it up into groups. > > - If you want to set Prefix: (to make the package relocatable), you need > to have a good reason. Most likely, you just want to take that line out. > > - I'm not sure why you're defining Docdir. Take that line out too. > > - You need to include a copy of the MIT license as a %doc. This isn't in > the upstream package, but it almost definitely should be. The only bit > of sourcecode in the package says to look in the "Copyright" file for > the license. But... there is no Copyright file. > > Please make those changes, then I'll re-review. > In addition to Tom's suggestions, your Source url needs to be corrected. /B -- Brian Pepple <bdpepple ameritech net> gpg --keyserver pgp.mit.edu --recv-keys 810CC15E BD5E 6F9E 8688 E668 8F5B CBDE 326A E936 810C C15E
Attachment:
signature.asc
Description: This is a digitally signed message part