Am Mi, den 03.08.2005 schrieb Paul Howarth um 11:22:
Thanks Paul for your review!
Thanks to Warren and Michael too for discussing what to set as
requirements.
> Bad:
>
> Source0 URL wrong. Instead of:
> http://www.rcs.ei.tum.de/~maierkom/privat/software/mbuffer/%{name}/%{name}-%{version}.tgz
>
> use:
> http://www.rcs.ei.tum.de/~maierkom/privat/software/mbuffer/mbuffer-%{version}.tgz
> (expanding %{name} is just my cosmetic preference here)
Corrected, stupid mistake by me.
> Should probably BuildRequire: mt-st and openssl-devel for additional
> functionality. Otherwise, you get this from configure:
> ...
> checking for mt... ./configure: line 2787: WARNING:: command not found
> no
> ...
> checking for library containing MD5_Init... no
> checking for library containing mhash_init... no
> checking for library containing MD5Init... no
> configure: WARNING: could not find the mhash library containing the md5
> hash functions - md5 support disabled
>
> Fix these and it's approved.
>
> Paul.
Good question what to set as build requirement - I followed the
discussion. Setting BR mt-st I would not have a problem with, as that
package is very small and I think mbuffer is a good candidate to show
tape storage movements. The more vital question is about openssl-devel
as BR, which means mbuffer will require openssl to be installed.
Certainly the feature to generate md5 hashes of transferred data is a
nice feature - does it justify the need to have openssl installed
altogether? I am open for opinions.
Would it be a strategy to offer a rebuild option "--with m5hash" for
those who like to have that feature and a BR in condition of such
parameter?
Alexander
--
1024D/866ED681 2005-07-11 Alexander Dalloz (Fedora Project) <alex dalloz de>
Key fingerprint = CD40 0A91 7814 C1E4 5940 8E0E 1FD5 C316 866E D681
Attachment:
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil