Re: Need help for open Requests

[Oliver Falk <oliver linux-kernel at>]

On 08/03/2005 04:59 PM, Jochen Schmitt wrote:
> I need further help to finish the folloing requests:
>
> URL:
> https://www.redhat.com/archives/fedora-extras-list/2005-July/msg01529.html
>
> Topic: New Package: highlight
>
> Problem: No respons or any comments about it.
[ ... ]
> It will be nice, if anyone have the patient to help me.

Had only a climpse at highlight yet.

+ Package builds fine
+ Package installs fine
+ Package uninstalls fine
+ Source matches upstream
+ URL OK
+ Specfilename matches %{name}
+ Package builds fine on FC4
+ rpmlint is quiet
+ no locales
+ COPYING in %doc
- Inconsistant use of macros
- Wrong BuildRoot
- patch backup extension (renamed, so it makes more 'sense')
- no dist-tag
- in install an clean only rm -rf $RPM_BUILD_ROOT should be used

* Changed %doc to 1 line
* %files section cleaned; */* is fine here.

Question: Do we really want {extensions,scriptre}.conf and in 
/usr/share/highlight? I think it would be better adding a 
/etc/hightlight directory.

Feel free to kick out my identation and revert back to yours...

See attached patch.

Best,
 Oliver

1c1,2
< Name: 	highlight
---
> Name:       highlight
> Summary:    A universal source code to formatted text converter
3,5c4,5
< Summary: A universal source code to formatted text converter
< Version: 2.4
< Release: 1
---
> Version:    2.4
> Release:    1%{?dist}
7c7,8
< Group: 	Development/Tools
---
> URL:        http://www.andre-simon.de/
> License:    GPL
9,13c10,11
< License: GPL
< 
< URL: http://www.andre-simon.de/
< 
< Source0:	http://www.andre-simon.de/zip/%{name}-%{version}-%{release}.tar.bz2
---
> Source0:    http://www.andre-simon.de/zip/%{name}-%{version}-%{release}.tar.bz2
> Group:      Development/Tools
17c15
< Buildroot:      %{_tmppath}/%{name}-%{version}-%{release}-root
---
> Buildroot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
28,29c26,27
< %setup -q -n highlight-%{version}-%{release}
< %patch1 -p1 -b .org
---
> %setup -q -n %{name}-%{version}-%{release}
> %patch1 -p1 -b .paths
35c33
< if [ -d $RPM_BUILD_ROOT ]; then rm -r $RPM_BUILD_ROOT; fi
---
> rm -rf $RPM_BUILD_ROOT
42c40
< rm -fr %{buildroot}
---
> rm -rf $RPM_BUILD_ROOT
51,67c49,54
< %dir %{_datadir}/highlight/langDefs
< %{_datadir}/highlight/langDefs/*.lang
< %dir %{_datadir}/highlight/themes
< %{_datadir}/highlight/themes/*.style
< %dir %{_datadir}/highlight/indentSchemes
< %{_datadir}/highlight/indentSchemes/*.indent
< %dir %{_datadir}/highlight/helpmsg
< %{_datadir}/highlight/helpmsg/*.help
< 
< %{_mandir}/man1/highlight.1.gz
< 
< %doc ChangeLog
< %doc AUTHORS
< %doc README*
< %doc COPYING
< %doc TODO
< %doc examples//
---
> %dir %{_datadir}/highlight/*
> %{_datadir}/highlight/*/*
> 
> %{_mandir}/man1/highlight*
> 
> %doc ChangeLog AUTHORS README* COPYING TODO examples/
72d58
<