Re: Request For Review: lout (was Re: rpm package of lout)

["Tom 'spot' Callaway" <tcallawa redhat com>]

On Fri, 2005-07-01 at 02:26 +0200, Ralf Corsepius wrote:
> On Thu, 2005-06-30 at 14:22 -0500, Tom 'spot' Callaway wrote:
> 
> > 
> > New SPEC: http://www.auroralinux.org/people/spot/review/lout.spec
> > New SRPM:
> > http://www.auroralinux.org/people/spot/review/lout-3.30-2.src.rpm
> > 
> > Please re-review
> 
> Now, you're inconsistent with using directories. At some places you are
> using /usr/bin etc., at others %{_bindir} ...

Fixed for consistent macro use.

Get another Fedora Extras contributor or Red Hat engineer (but not
yourself) to be the primary reviewer and the approver of your package.

> Another minor nit: There are traces of a lout-devel package inside of
> the spec, but a *-devel package is not being built.

Fixed.

> > (or approve).
> Ahh! - Seems as if the approval policy has changed ...

Actually, no. The policy says "Get another Fedora Extras contributor or
Red Hat engineer (but not yourself) to be the primary reviewer and the
approver of your package.".

You've got CVS extras commit access, therefore, you can review and
approve packages.

I've even documented the basic steps to look for in a review here:
http://fedoraproject.org/wiki/PackageReviewGuidelines

So, here are the fixed SRPM and SPEC:

SRPM: http://www.auroralinux.org/people/spot/review/lout-3.30-3.src.rpm
SPEC: http://www.auroralinux.org/people/spot/review/lout.spec

Please review (and approve, if it passes review).

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!