Oliver Falk wrote:On 07/01/2005 11:00 AM, Ralf Corsepius wrote:
Hi,
Another perl module: perl-Want.
%description This module generalises the mechanism of the wantarray function, allowing a function to determine in some detail how its return value is going to be immediately used.
Files: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Want.spec ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Want-0.08-1.src.rpm
Review (and approval) appreciated, TIA
Is the license Artistic or is it GPL?
Both. The package is dual-licensed, as are many other perl modules.
OK. Just wanted to be sure!
The perl specfile template suggests the following for %install:
rm -rf $RPM_BUILD_ROOT make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';' find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';' find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';' chmod -R u+w $RPM_BUILD_ROOT/*
Also it suggests the following for make: make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"
The OPTIMIZE is missing in your spec.
He's set CFLAGS manually; I'd rather see it following the perl spec template too.
So, that's on his todo-list. :-)
Best, Oliver