Re: Request for review: perl-Number-Compare

[Paul Howarth <paul city-fan org>]

Ralf Corsepius wrote:
> On Fri, 2005-07-01 at 10:32 +0100, Paul Howarth wrote:
> > - I'd put %check after %install rather than after %clean, so that builds 
> > on rpm versions not supporting %check could still work.
>
> I verified it works on FC3 and FC4 + inside of mock on FC4.

It will do, because those versions have an rpm that supports %check. 
Some older versions of rpm don't, and it won't work on those. If you're 
not bothered about supporting them, you don't need the "|| :" after %check.

> I don't see a license issue. 
> Want.pm contains:
>
> Copyright (c) 2001-2003, Robin Houston. All Rights Reserved.
> This module is free software. It may be used, redistributed
> and/or modified under the same terms as Perl itself.
>
> This is the standard perl license as being used by the perl package in FC:
> # rpm -q --qf '%{LICENSE}\n' perl
> Artistic or GPL

The issue isn't the licenses themselves, it's that the text of the 
license isn't included in the package (and many other perl module packages).

Paul.