Re: Request for review: perl-Want

[Oliver Falk <oliver linux-kernel at>]

On 07/01/2005 11:45 AM, Ralf Corsepius wrote:
> On Fri, 2005-07-01 at 11:26 +0200, Oliver Falk wrote:
>
> > Hi Ralf!
> >
> > On 07/01/2005 11:00 AM, Ralf Corsepius wrote:
> >
> > > Hi,
> > >
> > > Another perl module: perl-Want.
> > >
> > > %description
> > > This module generalises the mechanism of the wantarray
> > > function, allowing a function to determine in some detail
> > > how its return value is going to be immediately used.
> > >
> > > Files:
> > > ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Want.spec
> > > ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Want-0.08-1.src.rpm
> > >
> > > Review (and approval) appreciated, TIA
> >
> > Is the license Artistic or is it GPL?
>
>
> Have a look at the end of:
> http://search.cpan.org/src/ROBIN/Want-0.08/Want.pm
>
> It is the standard perl licence, i.e. "GPL or Artistic".

Ok.

> > The perl specfile template suggests the following for %install:
> >
> > rm -rf $RPM_BUILD_ROOT
> > make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
> > find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
> > find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
> > find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
> > chmod -R u+w $RPM_BUILD_ROOT/*
>
> This would be a bit more general than what I use, but doesn't have any
> impact on this package's behavior.

It's just because the perl spec template does it this way, so I 
recommend it as well!

> > Also it suggests the following for make:
> > make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"
> >
> > The OPTIMIZE is missing in your spec.
>
> Nope. It is set and is being used:
>
> ...
> Writing Makefile for Want
> + make
> cp Want.pm blib/lib/Want.pm
> /usr/bin/perl /usr/lib/perl5/5.8.6/ExtUtils/xsubpp
> -typemap /usr/lib/perl5/5.8.6/ExtUtils/typemap  Want.xs > Want.xsc && mv
> Want.xsc Want
> gcc -c   -D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing
> -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> -I/usr/include/gdbm -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2
> -fexceptions -m32 -march=i386 -mtune=pentium4
> -fasynchronous-unwind-tables
> -DVERSION=\"0.08\" -DXS_VERSION=\"0.08\" -fPIC
> "-I/usr/lib/perl5/5.8.6/i386-linux-thread-multi/CORE"   Want.c
> ...

As above, I just noted, that it's written this way in the template!

Best,
 Oliver