Re: Request for Review: Rekall and dependencies

[Adrian Reber <adrian lisas de>]

On Mon, Jul 18, 2005 at 06:35:23PM -0500, Tom 'spot' Callaway wrote:
> > readline-devel is also required as BR
> 
> Fixed. New spec and SRPM:
> SRPM: http://auroralinux.org/people/spot/review/xbsql-0.11-3.src.rpm
> SPEC: http://auroralinux.org/people/spot/review/xbsql.spec
> 
> Once more (with feeling), please review/approve. ;)

+ builds in mock
+ clean installation and removal
+ spec looks good
+ correct usage of -devel subpackage
+ source verified against upstream
+ rpmlint is happy
+ binary seems to work

Looks good, APPROVED.

You should probably add a Requires on xbase-devel for the xbsql-devel
subpackage, as the xbsql header file uses the xbase header files.
With this change you could remove the BR on xbase-devel from the rekall
spec file.

		Adrian

-- 
Adrian Reber <adrian lisas de>            http://lisas.de/~adrian/
Overload -- core meltdown sequence initiated.