[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: gnome-applet-bubblemon



On Thu, 2005-07-28 at 07:24 -0300, Nicolás Wolovick wrote:
> SPEC:http://www.cs.famaf.unc.edu.ar/~nicolasw/Otros/gnome-applet-bubblemon.spec

- Remove the hardcoded disttags
- Remove the explicit Requires
- --prefix and --mandir are redundant with %configure
- Variables should come after make in the command line, not before
- Use install, not install-strip in %install
- Should not own %{_datadir}/gnome-2.0
- Use %find_lang instead of owning %{_datadir}/locale

-- 
Ignacio Vazquez-Abrams <ivazquez ivazquez net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]