Re: Package seeking review: libsvg

[Ralf Corsepius <rc040203 freenet de>]

On Fri, 2005-07-29 at 02:52 -0400, Christopher Aillon wrote:
> http://people.redhat.com/caillon/RPMS/rawhide/libsvg.spec
> http://people.redhat.com/caillon/RPMS/rawhide/libsvg-0.1.4-1.src.rpm

Basically OK, with a few minor gripes:
- Doc files in /usr/share/*/* are executable. They should be
non-executable.

- I would recommend to disable building static libs
%configure --disable-static

o You are shipping libtool archives.
Some people around here feel religious about it and will want you to not
ship them - I consider shipping *.la's to be correct ;)

- The base-package's
Requires:         libxml2 >= %{libxml2_version}
probably is not necessary.

- rpmlint complains about the dot in the summary:
W: libsvg summary-ended-with-dot A generic SVG library.

o The devel package ships pkgconfig files. It might be worth considering
to let this package 'BR: pkgconfig'.

Ralf