Re: Request for review: gnome-applet-bubblemon

[Nicolás Wolovick <nwolovick gmail com>]

>--------- Mensaje reenviado ----------
>From: Ignacio Vazquez-Abrams <ivazquez ivazquez net>
>To: Discussion related to Fedora Extras <fedora-extras-list redhat com>
>Date: Thu, 28 Jul 2005 08:42:17 -0400
>Subject: Re: Request for review: gnome-applet-bubblemon
>On Thu, 2005-07-28 at 07:24 -0300, Nicolás Wolovick wrote:
>> SPEC:http://www.cs.famaf.unc.edu.ar/~nicolasw/Otros/gnome-applet-bubblemon.spec
>
>- Remove the hardcoded disttags
>- Remove the explicit Requires
>- --prefix and --mandir are redundant with %configure
>- Variables should come after make in the command line, not before
>- Use install, not install-strip in %install
>- Should not own %{_datadir}/gnome-2.0
>- Use %find_lang instead of owning %{_datadir}/locale

Thanks for the tips. I've updated the package and here you can find it.

SPEC:http://www.cs.famaf.unc.edu.ar/~nicolasw/Otros/gnome-applet-bubblemon.spec
SRPM:http://www.cs.famaf.unc.edu.ar/~nicolasw/Otros/gnome-applet-bubblemon-2.0.4-3.src.rpm

Please tellme how to follow the process if everything is ok.

Regards, Nicolas