Re: Request for Review: gnomesword

[Nils Philippsen <nphilipp redhat com>]

On Tue, 2005-05-31 at 03:53 -0700, Michael A. Peters wrote:
> http://mpeters.us/fc_extras/gnomesword.spec
> http://mpeters.us/fc_extras/gnomesword-2.1.2-0.1.src.rpm
> 

Suggested changes:
--- 8< ---
--- gnomesword.spec.orig        2005-05-31 12:45:35.000000000 +0200
+++ gnomesword.spec     2005-06-01 15:55:39.000000000 +0200
@@ -3,7 +3,7 @@
 Release:        0.1
 Summary:        GNOME-based Bible research tool

-Group:          Applications/Productivity
+Group:          Applications/Text
 License:        GPL
 URL:            http://gnomesword.sourceforge.net/
 Source0:        http://easynews.dl.sourceforge.net/sourceforge/gnomesword/gnomesword-%{version}.tar.gz
@@ -30,7 +30,6 @@
 BuildRequires: scrollkeeper
 BuildRequires: zlib-devel
 Requires(pre): scrollkeeper
-Requires:       sword >= 1.5.7.100
 Obsoletes:     gnomesword2

 %description
@@ -72,11 +71,9 @@
 %clean
 rm -rf %buildroot

-%post
-/usr/bin/scrollkeeper-update
+%post -p /usr/bin/scrollkeeper-update

-%postun
-/usr/bin/scrollkeeper-update
+%postun -p /usr/bin/scrollkeeper-update

 %files -f %{name}.lang
 %defattr(-,root,root,-)
--- >8 ---

Besides that, sponsored and approved.

Nils
-- 
     Nils Philippsen    /    Red Hat    /    nphilipp redhat com
"They that can give up essential liberty to obtain a little temporary
 safety deserve neither liberty nor safety."     -- B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011