Re: Request for review : php-pecl-pdo and php-pecl-pdo-sqlite

[Matthias Saou <thias spam spam spam spam spam spam spam egg and spam freshrpms net>]

Ignacio Vazquez-Abrams wrote :

> php-pecl-pdo:
> 
> + Source and URL are good
> - Does not build as-is. Fails when running phpize:
> 
> > + phpize
> > Cannot find config.m4.
> > Make sure that you run '/usr/bin/phpize' in the top level source directory of the module
> 
> Looks like the %setup and phpize order is swapped. Builds fine as non-
> root when this is fixed.
> + Ownership is good
> - Documentation should not be marked executable

Hum, seems like a last minute copy/paste made me put phpize after %prep
instead of %build. Fixed. The +x bit on all files is now also removed.

> php-pecl-pdo-sqlite:
> 
> + Source and URL are good
> + Builds as non-root
> + Ownership and permissions are good
> 
> Fix the small problems with php-pecl-pdo then consider it approved.

Great, thanks.

Matthias

-- 
Clean custom Red Hat Linux rpm packages : http://freshrpms.net/
Fedora Core release 3 (Heidelberg) - Linux kernel 2.6.11-1.27_FC3
Load : 2.58 1.05 0.60