Re: New package: istanbul

["John (J5) Palmieri" <johnp redhat com>]

A new spec and srpm is up with your suggestions added:

SRPM: http://people.redhat.com/johnp/istanbul/istanbul-0.1.0-2.src.rpm
SPEC: http://people.redhat.com/johnp/istanbul/istanbul.spec

On Wed, 2005-06-29 at 15:54 +0100, Mark McLoughlin wrote:
> Hey,
> 	Quick comments:
> 
>   - See sabayon.spec for some foo to require a specific python ABI
>     version and figure out the path for site-packages:
> 
> http://cvs.fedora.redhat.com/viewcvs/*checkout*/devel/sabayon/sabayon.spec?root=extras
> 
>     I think its in the packaging guidelines.
> 
>   - You should own the site-packages/istanbul/ dir
> 
>   - Instead of re-autogen-ing for the patch, you could consider 
>     including a diff of the autogened files. It could turn out to be 
>     pretty ugly, but sometimes I've found it to work out better than 
>     doing it at buildtime.
> 
>   - Otherwise you need to BuildRequire: autoconf automake
> 
>   - I doubt the BuildRequires: libtool is correct
> 
>   - update-desktop-database isn't needed unless you've got MimeType=foo 
>     AFAIR
> 
>   - should desktop-file-install the .desktop file and BuildRequire: 
>     desktop-file-utils
> 
>   - Do you need to call ldconfig ?
> 
> Cheers,
> Mark.
> 
> --
> fedora-extras-list mailing list
> fedora-extras-list redhat com
> https://www.redhat.com/mailman/listinfo/fedora-extras-list
--