Re: Review needed: bzflag

[Adrian Reber <adrian lisas de>]

On Fri, Mar 04, 2005 at 05:00:34PM +0100, Nils Philippsen wrote:
> I just imported bzflag to CVS and it would be great if someone could
> review it.

Looks pretty good, but:

If you do not include curl-devel in the BuildRequires for a special
reason it would be good to disable curl usage in the configure script or
just add it as a BR.

I personally like the BuildRoot from the PackagingGuidlines better:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Package builds, installs and works.

		Adrian